Implemented audienceNetwork (facebook) bidder for ortb endpoint #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpanchyk
suggested changes
Apr 4, 2018
| .map(SeatBid::getBid) | ||
| .filter(Objects::nonNull) | ||
| .flatMap(Collection::stream) | ||
| .limit(1) |
There was a problem hiding this comment.
Limit is not applicable for OpenRTB. Should be removed.
| .build(); | ||
| } | ||
|
|
||
| private Imp makeImp(Imp imp, String pubId) { |
There was a problem hiding this comment.
Input arg pubId should be named like placementId.
| } | ||
|
|
||
| @Override | ||
| public Map<String, String> extractTargeting(ObjectNode ext) { | ||
| return Collections.emptyMap(); | ||
| } | ||
|
|
||
| private ExtImpFacebook parseExtImpFacebook(Imp imp) { |
There was a problem hiding this comment.
Rearrange all methods in call order, but not by public/private/etc for better reading.
|
|
||
| public class FacebookBidderTest extends VertxTest { | ||
|
|
||
| private static final String ENDPOINT_URL = "https://sovrn.com/openrtb2d"; |
| .flatExtracting(BidRequest::getImp) | ||
| .isEmpty(); | ||
| assertThat(result.getErrors()).hasSize(1) | ||
| .element(0).extracting(BidderError::getMessage) |
There was a problem hiding this comment.
.element(0) call can be skipped. Check all bellow cases for this pls.
| return null; | ||
| } | ||
|
|
||
| final int h = banner.getH(); |
There was a problem hiding this comment.
Do we sure in non-null values?
| return placementIdSplit[0]; | ||
| } | ||
|
|
||
| private Site makeSite(BidRequest bidRequest, String pubId) { |
There was a problem hiding this comment.
Method can be static. See all other pls.
rpanchyk
approved these changes
Apr 4, 2018
schernysh
pushed a commit
that referenced
this pull request
Nov 25, 2019
* Added support reading country from RSID cookie for GDPR * Added support reading country from RSID cookie for GDPR - fix PR * Added support reading country from RSID cookie for GDPR - fix PR * Added support reading country from RSID cookie for GDPR - add gdpr.rubicon.rsid-cookie-encryption-key property to docs * Merge branch 'master-rubicon' into gdpr-read-country-from-rsid-cookie # Conflicts: # docs/config-app.md # src/main/java/org/prebid/server/gdpr/GdprService.java # src/main/java/org/prebid/server/handler/SetuidHandler.java # src/main/java/org/prebid/server/spring/config/ServiceConfiguration.java # src/rpm/application.yaml # src/test/java/org/prebid/server/gdpr/GdprServiceTest.java # src/test/resources/org/prebid/server/ApplicationTest/test-application.properties
VeryExtraordinaryUsername
added a commit
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.